projects / emacs.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: c69c17d) | patch
Calc: fix arithmetic right shift sign bit detection
authorMattias Engdegård <mattiase@acm.org>
Fri, 9 Oct 2020 09:12:53 +0000 (11:12 +0200)
committerMattias Engdegård <mattiase@acm.org>
Fri, 9 Oct 2020 09:24:15 +0000 (11:24 +0200)
commit35478f3f76d55f640372028889c570647432859c
tree3744cb3c1b0f9c159214a24f24ae4551386a852btree | snapshot
parentc69c17d573860ebe74320cee2a1850baa865183dcommit | diff
Calc: fix arithmetic right shift sign bit detection

Arithmetic right shift didn't compute the bit to shift in correctly.
For example, #x600000000 right-shifted 8 steps (with 32 bit word size)
resulted in #xff000000 rather than 0. (Bug#43764)

* lisp/calc/calc-bin.el (calcFunc-ash): Fix condition.
* test/lisp/calc/calc-tests.el (calc-tests--clip, calc-tests--lsh)
(calc-tests--rsh, calc-tests--ash, calc-tests--rash, calc-tests--rot):
New.
(calc-shift-binary): New test.
lisp/calc/calc-bin.el diff | blob | history
test/lisp/calc/calc-tests.el diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.